sage -package download: Fix argparse for --no-check-certificate
#36947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbraun This fixes the macOS CI; please review |
mkoeppe
force-pushed
the
ci-macos-fix--no-check-certificate
branch
from
d7c1dd4
to
de08b80
Compare
|
Documentation preview for this PR (built with commit de08b80; changes) is ready! 🎉 |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 27, 2023
…eck-certificate` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> A mistake in sagemath#36774 broke the macOS CI in 10.3.beta3, see https://github.com/sagemath/sage/actions/runs/7255417440/job/19765989346 #step:9:1425 ``` [patch-2.7.5] error installing, exit status 1. End of log file: [patch-2.7.5] usage: sage --package [-h] [--log LOG] [--no-check- certificate] [patch-2.7.5] {config,list,name,tarball,apropos,update,update- latest,download,upload,fix-checksum,create,clean} [patch-2.7.5] ... [patch-2.7.5] sage --package: error: unrecognized arguments: --no- check-certificate [patch-2.7.5] ************************************************************************ [patch-2.7.5] Error downloading tarball of patch [patch-2.7.5] ************************************************************************ ``` We make the one-line fix for this here. Tests (with other merged branches) at https://github.com/mkoeppe/sage/actions/runs/7295997767/job/19883171237 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36947 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
…eck-certificate`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
A mistake in sagemath#36774 broke the macOS CI in 10.3.beta3, see
https://github.com/sagemath/sage/actions/runs/7255417440/job/19765989346
#step:9:1425
```
[patch-2.7.5] error installing, exit status 1. End of log file:
[patch-2.7.5] usage: sage --package [-h] [--log LOG] [--no-check-
certificate]
[patch-2.7.5]
{config,list,name,tarball,apropos,update,update-
latest,download,upload,fix-checksum,create,clean}
[patch-2.7.5] ...
[patch-2.7.5] sage --package: error: unrecognized arguments: --no-
check-certificate
[patch-2.7.5]
************************************************************************
[patch-2.7.5] Error downloading tarball of patch
[patch-2.7.5]
************************************************************************
```
We make the one-line fix for this here.
Tests (with other merged branches) at
https://github.com/mkoeppe/sage/actions/runs/7295997767/job/19883171237
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36947
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
…eck-certificate`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
A mistake in sagemath#36774 broke the macOS CI in 10.3.beta3, see
https://github.com/sagemath/sage/actions/runs/7255417440/job/19765989346
#step:9:1425
```
[patch-2.7.5] error installing, exit status 1. End of log file:
[patch-2.7.5] usage: sage --package [-h] [--log LOG] [--no-check-
certificate]
[patch-2.7.5]
{config,list,name,tarball,apropos,update,update-
latest,download,upload,fix-checksum,create,clean}
[patch-2.7.5] ...
[patch-2.7.5] sage --package: error: unrecognized arguments: --no-
check-certificate
[patch-2.7.5]
************************************************************************
[patch-2.7.5] Error downloading tarball of patch
[patch-2.7.5]
************************************************************************
```
We make the one-line fix for this here.
Tests (with other merged branches) at
https://github.com/mkoeppe/sage/actions/runs/7295997767/job/19883171237
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36947
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mistake in #36774 broke the macOS CI in 10.3.beta3, see
https://github.com/sagemath/sage/actions/runs/7255417440/job/19765989346#step:9:1425
We make the one-line fix for this here.
Tests (with other merged branches) at https://github.com/mkoeppe/sage/actions/runs/7295997767/job/19883171237
📝 Checklist
⌛ Dependencies