Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: Update voidlinux, update installation guide #36957

Merged
merged 14 commits into from
Jan 14, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Dec 25, 2023

To test: Use export DOCKER_TARGETS="with-system-packages configured with-targets-pre with-targets", then one of:

  • tox -e docker-voidlinux-standard-python3.11
  • tox -e docker-voidlinux-musl-standard-python3.11

Support for tox -e docker-voidlinux-standard-sitepackages will have to wait for:

This

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 25, 2023
@mkoeppe mkoeppe marked this pull request as ready for review December 26, 2023 02:23
@tornaria
Copy link
Contributor

For any void linux users out there:

$ sudo xbps-install sagemath
...

is in general quite up to date (10.2 right now). Feel free to report any issues in https://github.com/void-linux/void-packages/issues. We also have a draft PR tracking beta/rc sagemath prereleases (currently void-linux/void-packages#47712 tracking 10.3 prereleases)

Installing sagemath in any other way is unsupported. The main problem you could have is that, void being a rolling distro, the system packages will change and your locally compiled sage might break.

@mkoeppe mkoeppe changed the title tox.ini: Update voidlinux tox.ini: Update voidlinux, update installation guide Dec 27, 2023
@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 27, 2023

I'll defer other work on the installation guide to a follow up PR.

@tornaria
Copy link
Contributor

Documentation lgtm.

As explained above I'm not really interested, but just to see how it works I tried running tox -e docker-voidlinux-standard: it failed with Error building package python3-3.11.1 (actually, it didn't fail, it hanged after printing that error, and it actually seems to be grabbing 800% cpu -- it's been trashing my cpus for fflas_ffpack tests for something like 20+ minutes).

This is futile, why are you trying to build python?

BTW, I think xbps-install -Su is incorrect, if there were any updates available it would stop to ask for confirmation. To avoid that, do xbps-install -Suy.

You are also missing a bunch of packages (of course everything required is available as packages; nothing is vendored in in our sagemath package). Most notable:

  • cython, cysignals, cypari
  • linbox, givaro, fflas_ffpack
  • gap
  • databases
  • (all?) python packages...
  • numpy, ipython, jupyter, scipy, sympy... come on.
  • psutil: that's funny

For the names of required packages, see: https://github.com/void-linux/void-packages/blob/master/srcpkgs/sagemath/template

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 31, 2023

As explained above I'm not really interested, but just to see how it works I tried running tox -e docker-voidlinux-standard: it failed with Error building package python3-3.11.1 (actually, it didn't fail, it hanged after printing that error, and it actually seems to be grabbing 800% cpu -- it's been trashing my cpus for fflas_ffpack tests for something like 20+ minutes).

There's definitely something wrong with fflas_ffpack, we also see random hangs like you describe on other platforms in our CI. Hoping to get #35148 unstuck soon.

This is futile, why are you trying to build python?

It's probably rejecting python 3.12.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 31, 2023

You are also missing a bunch of packages (of course everything required is available as packages; nothing is vendored in in our sagemath package). Most notable:
[...]

  • (all?) python packages...

Yes, using system site packages is still only an experimental option @orlitzky. To test it with tox, one can use tox -e docker-voidlinux-standard-sitepackages. (But one needs a suitable system python first...)

For the names of required packages, see: https://github.com/void-linux/void-packages/blob/master/srcpkgs/sagemath/template

Thanks for the pointer! You added many of these packages in

I'll check what's new.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 31, 2023

#20 21.57 ## -------------------------------------------------------- ##
#20 21.57 ## Checking whether SageMath should install SPKG python3... ##
#20 21.57 ## -------------------------------------------------------- ##
#20 21.57 configure:39721: checking whether any of bzip2 liblzma libffi zlib is installed as or will be installed as SPKG
#20 21.57 configure:39731: result: no
#20 21.57 configure:39735: checking for python3 >= 3.9.0, < 3.12.0 with modules sqlite3, ctypes, math, hashlib, crypt, socket, zlib, distutils.core, ssl, ensurepip
#20 21.57 configure:39744: result: 
#20 21.57 configure:39748: checking for python3.11
#20 21.57 configure:39771: found /usr/sbin/python3.11
#20 21.57 configure:39783: result: /usr/sbin/python3.11
#20 21.57 configure:39800: checking ... whether /usr/sbin/python3.11 is good
#20 21.57 Traceback (most recent call last):
#20 21.57   File "/usr/lib/python3.11/crypt.py", line 6, in <module>
#20 21.57     import _crypt
#20 21.57 ModuleNotFoundError: No module named '_crypt'
#20 21.57 
#20 21.57 During handling of the above exception, another exception occurred:
#20 21.57 
#20 21.57 Traceback (most recent call last):
#20 21.57   File "<string>", line 1, in <module>
#20 21.57   File "/usr/lib/python3.11/crypt.py", line 11, in <module>
#20 21.57     raise ImportError("The required _crypt module was not built as part of CPython")
#20 21.57 ImportError: The required _crypt module was not built as part of CPython
#20 21.57 configure:40378: result: no, the version is in the supported range but cannot import one of the required modules: sqlite3, ctypes, math, hashlib, crypt, socket, zlib, distutils.core, ssl, ensurepip
#20 21.57 configure:40415: error: the python3 selected using --with-python=python3.11 is not suitable

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 31, 2023

According to https://docs.python.org/3/library/crypt.html: Deprecated since version 3.11, will be removed in version 3.13

I'll remove the check for it

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 31, 2023

tox is broken on voidlinux

@mkoeppe ➜ /workspaces/sage (tox_voidlinux) $ docker run -it sage-voidlinux-standard-python3.11-configured:8fdd9f0132 bash
bash-5.2# tox
Traceback (most recent call last):
  File "/usr/sbin/tox", line 33, in <module>
    sys.exit(load_entry_point('tox==3.28.0', 'console_scripts', 'tox')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/sbin/tox", line 25, in importlib_load_entry_point
    return next(matches).load()
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/metadata/__init__.py", line 205, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 994, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/usr/lib/python3.12/site-packages/tox/__init__.py", line 32, in <module>
    from .session import cmdline  # isort:skip
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/tox/session/__init__.py", line 22, in <module>
    from tox.config import INTERRUPT_TIMEOUT, SUICIDE_TIMEOUT, TERMINATE_TIMEOUT, parseconfig
  File "/usr/lib/python3.12/site-packages/tox/config/__init__.py", line 22, in <module>
    import six
ModuleNotFoundError: No module named 'six'

(Also unusable because it is outdated)

@tornaria
Copy link
Contributor

As explained above I'm not really interested, but just to see how it works I tried running tox -e docker-voidlinux-standard: it failed with Error building package python3-3.11.1 (actually, it didn't fail, it hanged after printing that error, and it actually seems to be grabbing 800% cpu -- it's been trashing my cpus for fflas_ffpack tests for something like 20+ minutes).

There's definitely something wrong with fflas_ffpack, we also see random hangs like you describe on other platforms in our CI. Hoping to get #35148 unstuck soon.

Isn't it just running a (very, very) long test suite?

Note that the new versions of givaro, fflas, and linbox are supported since 10.1 (#35612) so even without #35148 it should be possible to use them just fine.

All the upper bounds on unreleased package versions are really bad. Should just get rid of all of them.

This is futile, why are you trying to build python?

It's probably rejecting python 3.12.

For no reason. Same as above.

BTW, I changed build/pkgs/python3/spkg-configure.m4 but tox -e docker-voidlinux-standard doesn't seem to take the new version, even after I rerun bootstrap.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

@tornaria Let's merge it?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

Thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

By the way, I had trouble to get voidlinux to work in a devcontainer. I don't know who the target user base of voidlinux is, but I think that's a showstopper for adoption by developers who use VS Code or want to use Codespaces or anything like that.

@tornaria
Copy link
Contributor

tornaria commented Jan 2, 2024

By the way, I had trouble to get voidlinux to work in a devcontainer.

I have no idea what is a "devcontainer".

I don't know who the target user base of voidlinux is,

Can scratch its own itch.

but I think that's a showstopper for adoption by developers who use VS Code or want to use Codespaces or anything like that.

Some might say this is a feature. But in fact there's actually a vscode package and it's up to date, so I don't see what is the problem.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

By the way, I had trouble to get voidlinux to work in a devcontainer.

I have no idea what is a "devcontainer".

Since you didn't say "... and I don't want to know": https://code.visualstudio.com/docs/devcontainers/containers

but I think that's a showstopper for adoption by developers who use VS Code or want to use Codespaces or anything like that.

Some might say this is a feature. But in fact there's actually a vscode package and it's up to date, so I don't see what is the problem.

It means for Sage that -- despite the competent packaging of Sage on voidlinux -- it's hard to recommend it as a deployment option for Sage for users who have to use Windows.

@tornaria
Copy link
Contributor

tornaria commented Jan 2, 2024

By the way, I had trouble to get voidlinux to work in a devcontainer.

I have no idea what is a "devcontainer".

Since you didn't say "... and I don't want to know": https://code.visualstudio.com/docs/devcontainers/containers

Ok, but what is the trouble you had, and what can be done on void linux side to improve your experience?

but I think that's a showstopper for adoption by developers who use VS Code or want to use Codespaces or anything like that.

Some might say this is a feature. But in fact there's actually a vscode package and it's up to date, so I don't see what is the problem.

It means for Sage that -- despite the competent packaging of Sage on voidlinux -- it's hard to recommend it as a deployment option for Sage for users who have to use Windows.

Still no idea what went wrong.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

what is the trouble you had, and what can be done on void linux side to improve your experience?

Let's take this to #36995

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

@tornaria Did you say you also package the current beta? What would I need to do to install it?

@tornaria
Copy link
Contributor

tornaria commented Jan 2, 2024

@tornaria Did you say you also package the current beta? What would I need to do to install it?

I do have a draft PR void-linux/void-packages#47712

It works perfectly fine, it's a draft only because void policy is to stick to main releases, and I wouldn't want to be updating sagemath every week anyways.

However, there are no binary packages for the beta release: you'd have to build it from source using xbps-src. Roughly speaking: clone my branch of the void repo, run xbps-src to build the sagemath package; this will create a local repo with the packages needed, and you can install from there into the running system.

If you find this could be useful, I can do it from scratch and record step by steps (this would be 3-4 easy automatic steps). I guess one could also put the repo with the beta packages built in some public place, then just configure xbps to use that repo, but I don't do this.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 2, 2024

@tornaria Did you say you also package the current beta? What would I need to do to install it?

there are no binary packages for the beta release: you'd have to build it from source using xbps-src. Roughly speaking: clone my branch of the void repo, run xbps-src to build the sagemath package; this will create a local repo with the packages needed, and you can install from there into the running system.

If you find this could be useful, I can do it from scratch and record step by steps (this would be 3-4 easy automatic steps).

Yes, that would be great, thanks!

I guess one could also put the repo with the beta packages built in some public place, then just configure xbps to use that repo, but I don't do this.

No need for this.

@tornaria
Copy link
Contributor

tornaria commented Jan 2, 2024

Something like this should work:

git clone --depth=200 -b sagemath https://github.com/tornaria/void-packages void-sage
cd void-sage
git fetch --depth=500 https://github.com/void-linux/void-packages
git rebase FETCH_HEAD
./xbps-src binary-bootstrap
./xbps-src pkg sagemath
sudo xbps-install --repository=hostdir/binpkgs/sagemath sagemath

It's important that you rebase on top of the main repo to avoid rebuilding packages that have changed.

The pkg step you can change for ./xbps-src pkg -Q sagemath for running tests before packaging, and ./xbps-src pkg -K sagemath for running tests in long mode.

Once the package is built, all you need to share with other boxes to install the pkg should be in the local repo in hostdir/binpkgs/sagemath. The --repository option can in principle be a url; however I think for remote urls this requires signing the packages (you can always wget the files and use it as a local repo).

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 3, 2024

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 3, 2024

Something like this should work:

git clone --depth=200 -b sagemath https://github.com/tornaria/void-packages void-sage
cd void-sage
...

@tornaria Thanks! I've added this to #36995 as .devcontainer/downstream-voidlinux-tornaria in d650e13

@tornaria
Copy link
Contributor

tornaria commented Jan 3, 2024

Something like this should work:

git clone --depth=200 -b sagemath https://github.com/tornaria/void-packages void-sage
cd void-sage
...

@tornaria Thanks! I've added this to #36995 as .devcontainer/downstream-voidlinux-tornaria in d650e13

Is this usable from the command line, or only via vscode? If so, how? Does it work with podman or only with docker?

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 3, 2024

You can probably use https://github.com/devcontainers/cli but I have no experience with it

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
To test: Use `export DOCKER_TARGETS="with-system-packages configured
with-targets-pre with-targets"`, then one of:
- `tox -e docker-voidlinux-standard-python3.11`
- `tox -e docker-voidlinux-musl-standard-python3.11`

Support for `tox -e docker-voidlinux-standard-sitepackages` will have to
wait for:
- sagemath#36181

This
- Fixes sagemath#33084

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [ ] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36957
Reported by: Matthias Köppe
Reviewer(s):
@vbraun vbraun merged commit 3251d98 into sagemath:develop Jan 14, 2024
25 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Jan 14, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 27, 2024
…ing sphinx-inline-tabs

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Preview: https://deploy-preview-37056--
sagemath.netlify.app/html/en/installation/source#linux-system-package-
installation

Same for the SPKG pages in the reference manual. https://deploy-
preview-37056--
sagemath.netlify.app/html/en/reference/spkg/gfortran#equivalent-system-
packages

Same for the git instructions in the developer guide, using 2 tabs for
HTTPS and SSH: https://deploy-preview-37056--
sagemath.netlify.app/html/en/developer/github#forking-the-sage-
repository

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36957 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37056
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2024
…ing sphinx-inline-tabs

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Preview: https://deploy-preview-37056--
sagemath.netlify.app/html/en/installation/source#linux-system-package-
installation

Same for the SPKG pages in the reference manual. https://deploy-
preview-37056--
sagemath.netlify.app/html/en/reference/spkg/gfortran#equivalent-system-
packages

Same for the git instructions in the developer guide, using 2 tabs for
HTTPS and SSH: https://deploy-preview-37056--
sagemath.netlify.app/html/en/developer/github#forking-the-sage-
repository

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36957 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37056
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
…ing sphinx-inline-tabs

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Preview: https://deploy-preview-37056--
sagemath.netlify.app/html/en/installation/source#linux-system-package-
installation

Same for the SPKG pages in the reference manual. https://deploy-
preview-37056--
sagemath.netlify.app/html/en/reference/spkg/gfortran#equivalent-system-
packages

Same for the git instructions in the developer guide, using 2 tabs for
HTTPS and SSH: https://deploy-preview-37056--
sagemath.netlify.app/html/en/developer/github#forking-the-sage-
repository

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36957 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37056
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 1, 2024
…ing sphinx-inline-tabs

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Preview: https://deploy-preview-37056--
sagemath.netlify.app/html/en/installation/source#linux-system-package-
installation

Same for the SPKG pages in the reference manual. https://deploy-
preview-37056--
sagemath.netlify.app/html/en/reference/spkg/gfortran#equivalent-system-
packages

Same for the git instructions in the developer guide, using 2 tabs for
HTTPS and SSH: https://deploy-preview-37056--
sagemath.netlify.app/html/en/developer/github#forking-the-sage-
repository

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36957 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37056
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 11, 2024
… (setuptools instead of distutils)

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

- Cherry-picked from sagemath#36181

This PR does not change what versions are accepted!
To test with Python 3.12, still need to adjust the version bound set in
`build/pkgs/python3/spkg-configure.m4`.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36957 (merged here to resolve merge conflict)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36983
Reported by: Matthias Köppe
Reviewer(s): Gonzalo Tornaría, Matthias Köppe
@mkoeppe mkoeppe deleted the tox_voidlinux branch February 14, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox.ini: Fix voidlinux
3 participants