Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent in plural #37023

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Parent in plural #37023

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e23eb9f
from Ring to Parent in plural 1/3
fchapoton Jan 7, 2024
860ff8e
parent in plural step 2
fchapoton Jan 7, 2024
1f95cb0
parent in plural, step 3/3
fchapoton Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/sage/rings/polynomial/plural.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ from sage.rings.polynomial.multi_polynomial_libsingular cimport MPolynomialRing_
from sage.rings.polynomial.multi_polynomial_ideal import NCPolynomialIdeal

from sage.rings.polynomial.polydict import ETuple
from sage.rings.ring import check_default_category, Ring
from sage.rings.ring import check_default_category, CommutativeRing
from sage.structure.element cimport CommutativeRingElement, Element, RingElement
from sage.structure.factory import UniqueFactory
from sage.structure.richcmp cimport rich_to_bool
Expand Down Expand Up @@ -334,7 +334,7 @@ cdef class NCPolynomialRing_plural(Ring):
self._ngens = n
self._term_order = order

Ring.__init__(self, base_ring, names, category=category)
Parent.__init__(self, base=base_ring, names=names, category=category)
self._populate_coercion_lists_()

assert n == len(self._names)
Expand Down Expand Up @@ -2878,8 +2878,8 @@ cpdef MPolynomialRing_libsingular new_CRing(RingWrap rw, base_ring) noexcept:
self._term_order = TermOrder(rw.ordering_string(), force=True)

names = tuple(rw.var_names())
Ring.__init__(self, base_ring, names, category=Algebras(base_ring),
normalize=False)
CommutativeRing.__init__(self, base_ring, names, category=Algebras(base_ring),
normalize=False)

self._has_singular = True

Expand Down Expand Up @@ -2946,7 +2946,7 @@ cpdef NCPolynomialRing_plural new_NRing(RingWrap rw, base_ring) noexcept:
self._ngens = rw.ngens()
self._term_order = TermOrder(rw.ordering_string(), force=True)

Ring.__init__(self, base_ring, rw.var_names(), category=Algebras(base_ring))
Parent.__init__(self, base=base_ring, names=rw.var_names(), category=Algebras(base_ring))

self._has_singular = True
self._relations = self.relations()
Expand Down