Dont load all GAP packages when resetting a workspace #37049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently done in gap_reset_workspace(), but I think it's less surprising to find the GAP initialization in the GAP initialization file. Here we add it to sage.gaprc so that it can later be removed from gap_reset_workspace().
This is currently done in gap_reset_workspace(), but I think it's less surprising to find the GAP initialization in the GAP initialization file. Here we add it to sage.g (for the pexpect interface) so that it can later be removed from gap_reset_workspace(). It has already been added to sage.gaprc (for the library interface) in an earlier commit.
Resetting the GAP workspace already initializes a new Gap instance and loads our default collection of packages. There's no need to load anything else in gap_reset_workspace(). The disabling of the color prompt is now handled in both sage.gaprc and sage.g (both GAP interfaces) so we remove that as well. Fixes: sagemathGH-31761
|
@antonio-rojas does this help your memory usage? |
|
Documentation preview for this PR (built with commit 9cbf569; changes) is ready! 🎉 |
Yes, the only remaining issue with all gap-packages installed (besides the Browse issue) is the test in |
We already load-test those as soon as we use GAP in any other doctest. Now that |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
The `gap_reset_workspace()` function currently loops through all installed GAP packages (both by sage and on the system) and loads them before saving the new workspace. This is no longer necessary or desired: the two GAP initialization files already load a specific set of packages used in sage, and loading more can cause problems including wasted memory and unexpected changes of behavior. Moreover, the need for _users_ to load additional packages interactively has been documented. Fixes: - sagemath#31761 URL: sagemath#37049 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
The `gap_reset_workspace()` function currently loops through all installed GAP packages (both by sage and on the system) and loads them before saving the new workspace. This is no longer necessary or desired: the two GAP initialization files already load a specific set of packages used in sage, and loading more can cause problems including wasted memory and unexpected changes of behavior. Moreover, the need for _users_ to load additional packages interactively has been documented. Fixes: - sagemath#31761 URL: sagemath#37049 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2024
The `gap_reset_workspace()` function currently loops through all installed GAP packages (both by sage and on the system) and loads them before saving the new workspace. This is no longer necessary or desired: the two GAP initialization files already load a specific set of packages used in sage, and loading more can cause problems including wasted memory and unexpected changes of behavior. Moreover, the need for _users_ to load additional packages interactively has been documented. Fixes: - sagemath#31761 URL: sagemath#37049 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 22, 2024
These tests for the installed GAP packages are problematic in a world where Sage can use GAP from the system. Particularly, loading _all_ installed GAP packages is not a safe operation when there might be an enormous number of them. Moreover, with the system GAP, it's not really Sage's reponsibility to ensure that the installed packages load. It _would_ be nice to know that any extra packages from the gap_packages SPKG are installed correctly; however, that type of test would be more appropriate in that SPKG's spkg-check phase. Dependencies: - sagemath#37049 URL: sagemath#37076 Reported by: Michael Orlitzky Reviewer(s): Antonio Rojas
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
These tests for the installed GAP packages are problematic in a world where Sage can use GAP from the system. Particularly, loading _all_ installed GAP packages is not a safe operation when there might be an enormous number of them. Moreover, with the system GAP, it's not really Sage's reponsibility to ensure that the installed packages load. It _would_ be nice to know that any extra packages from the gap_packages SPKG are installed correctly; however, that type of test would be more appropriate in that SPKG's spkg-check phase. Dependencies: - sagemath#37049 URL: sagemath#37076 Reported by: Michael Orlitzky Reviewer(s): Antonio Rojas
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
These tests for the installed GAP packages are problematic in a world where Sage can use GAP from the system. Particularly, loading _all_ installed GAP packages is not a safe operation when there might be an enormous number of them. Moreover, with the system GAP, it's not really Sage's reponsibility to ensure that the installed packages load. It _would_ be nice to know that any extra packages from the gap_packages SPKG are installed correctly; however, that type of test would be more appropriate in that SPKG's spkg-check phase. Dependencies: - sagemath#37049 URL: sagemath#37076 Reported by: Michael Orlitzky Reviewer(s): Antonio Rojas
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
These tests for the installed GAP packages are problematic in a world where Sage can use GAP from the system. Particularly, loading _all_ installed GAP packages is not a safe operation when there might be an enormous number of them. Moreover, with the system GAP, it's not really Sage's reponsibility to ensure that the installed packages load. It _would_ be nice to know that any extra packages from the gap_packages SPKG are installed correctly; however, that type of test would be more appropriate in that SPKG's spkg-check phase. Dependencies: - sagemath#37049 URL: sagemath#37076 Reported by: Michael Orlitzky Reviewer(s): Antonio Rojas
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 1, 2024
These tests for the installed GAP packages are problematic in a world where Sage can use GAP from the system. Particularly, loading _all_ installed GAP packages is not a safe operation when there might be an enormous number of them. Moreover, with the system GAP, it's not really Sage's reponsibility to ensure that the installed packages load. It _would_ be nice to know that any extra packages from the gap_packages SPKG are installed correctly; however, that type of test would be more appropriate in that SPKG's spkg-check phase. Dependencies: - sagemath#37049 URL: sagemath#37076 Reported by: Michael Orlitzky Reviewer(s): Antonio Rojas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gap_reset_workspace()function currently loops through all installed GAP packages (both by sage and on the system) and loads them before saving the new workspace. This is no longer necessary or desired: the two GAP initialization files already load a specific set of packages used in sage, and loading more can cause problems including wasted memory and unexpected changes of behavior. Moreover, the need for users to load additional packages interactively has been documented.Fixes: