Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean singular interface (full pep8) + use standard open and zip #37062

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

fchapoton
Copy link
Contributor

This is

  • cleaning for pep8 compliance the singular pexpect interface
  • making sure to use everywhere the standard zip and open

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 2643ec3; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2024
… open and zip

    
This is

- cleaning for pep8 compliance the `singular` pexpect interface
- making sure to use everywhere the standard `zip` and `open`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37062
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2024
… open and zip

    
This is

- cleaning for pep8 compliance the `singular` pexpect interface
- making sure to use everywhere the standard `zip` and `open`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37062
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit b7b654e into sagemath:develop Jan 22, 2024
15 of 20 checks passed
@fchapoton fchapoton deleted the pep8-clean-singular-interface branch January 22, 2024 08:36
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants