Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Parent in number fields and QQ #37069

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Use Parent in number fields and QQ #37069

merged 3 commits into from
Jan 22, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jan 16, 2024 •
edited

Towards the removal of ParentWithGens : use parent in number fields and in QQ

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title Use parent number field qq Use Parent in number fields and QQ Jan 16, 2024
tscrim
tscrim approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry; just one small while-we-are-at-it thing. You can set a positive review once changed or decided to ignore.

src/sage/rings/rational_field.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 936661d; changes) is ready! 馃帀

@fchapoton
Copy link
Contributor Author

ok, setting to positive, thanks

@vbraun vbraun merged commit e31cc79 into sagemath:develop Jan 22, 2024
19 checks passed
@fchapoton fchapoton deleted the use_parent_number_field_QQ branch January 22, 2024 08:36
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: number fields t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe