Update portability tests to use Meson #37077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to meson-compile
/opt/conda/envs/sage-dev/x86_64-conda-linux-gnu/include/c++/12.3.0/bits/stl_tree.h:772:15: error: static assertion failed: comparison object must be invocable as const 772 | is_invocable_v<const _Compare&, const _Key&, const _Key&>, /opt/conda/envs/sage-dev/x86_64-conda-linux-gnu/include/c++/12.3.0/bits/stl_tree.h:772:15: note: 'std::is_invocable_v<const bernmm::Item_cmp&, bernmm::Item* const&, bernmm::Item* const&>' evaluates to false
Reason: Cython uses the working dir to relativize the file name (see https://github.com/cython/cython/blob/2f93a5f92a80352e72f5fa9679fd282cb7a497ad/Cython/Compiler/Scanning.py#L199-L200), but meson runs the compilation from a temporary folder (https://github.com/mesonbuild/meson/blob/e991c4d45460c09e5eaee6cb1041edb95d1e990e/mesonbuild/compilers/compilers.py#L832-L879). Hence this the file name relatization is not working.
This reverts commit 395c310.
5 tasks
|
Documentation preview for this PR (built with commit 042c42e; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 30, 2024
…tros
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Add/update a few missing system packages, mostly for Arch and Fedora.
Needed for sagemath#37077.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37579
Reported by: Tobias Diez
Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo:
📝 Checklist
⌛ Dependencies