Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convenience method to construct elliptic-curve isomorphisms from u,r,s,t #37081

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Jan 17, 2024

The EllipticCurve_generic class has methods for computing an isomorphism between two given curves as well as computing the codomain of a particular isomorphism (specified by its coefficients $u,r,s,t$).

What it does not currently have is a method for computing an isomorphism from its (co)domain and the coefficients $u,r,s,t$. The best way to construct such an isomorphism is currently to from sage.schemes.elliptic_curves.weierstrass_morphism import WeierstrassIsomorphism, which is less than convenient. In this patch we add the desired method.

#sd123

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also say something about the default values of rst. (Or perhaps this is obvious to an expert?) Otherwise LGTM.

@yyyyx4
Copy link
Member Author

yyyyx4 commented Jan 18, 2024

Thanks, done. (I'd say zero is definitely the single obvious choice for $r,s,t$, but it can't hurt to state it explicitly anyway.)

Copy link

Documentation preview for this PR (built with commit 89f8531; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@vbraun vbraun merged commit cf322e4 into sagemath:develop Jan 22, 2024
20 checks passed
@yyyyx4 yyyyx4 deleted the public/construct_elliptic_curve_isomorphisms_from_urst branch January 22, 2024 01:06
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants