use parent in Ore polynomials #37087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ab87e17; changes) is ready! 馃帀 |
|
Looks good to me! |
xcaruso
approved these changes
Jan 28, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
this is using `Parent` in Ore polynomial and fractions
also some typing annotations and other little details in the 2 modified
files.
also moving a method to the category of rings (could go higher in the
hierarchy maybe)
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37087
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
this is using `Parent` in Ore polynomial and fractions
also some typing annotations and other little details in the 2 modified
files.
also moving a method to the category of rings (could go higher in the
hierarchy maybe)
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37087
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Xavier Caruso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is using
Parentin Ore polynomial and fractionsalso some typing annotations and other little details in the 2 modified files.
also moving a method to the category of rings (could go higher in the hierarchy maybe)
馃摑 Checklist