Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .is_isomorphic for rational quaternion algebras #37107

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

S17A05
Copy link
Contributor

@S17A05 S17A05 commented Jan 19, 2024

Added QuaternionAlgebra_ab.is_isomorphic() to conveniently check whether two rational quaternion algebras are isomorphic.

TODO (future work):

  • [] Extend isomorphism check to quaternion algebras over number fields.

#sd123

Added `QuaternionAlgebra_ab.is_isomorphic()` to conveniently check whether two rational quaternion algebras are isomorphic
@pjbruin
Copy link
Contributor

pjbruin commented Jan 19, 2024

Could you add a type check to verify that A is a quaternion algebra?

@S17A05 S17A05 force-pushed the is_isomorphic branch 2 times, most recently from 34aa814 to 4fc542c Compare January 20, 2024 00:43
@S17A05
Copy link
Contributor Author

S17A05 commented Jan 20, 2024

Could you add a type check to verify that A is a quaternion algebra?

Added a check to make sure $A$ is a quaternion algebra of the form $A = (a,b)_K$ since .discriminant() depends on this type of quaternion algebra representation - thanks for bringing this up!

Added a type check to .is_isomorphic to ensure that A is a quaternion algebra of the form (a,b)_K.
@S17A05
Copy link
Contributor Author

S17A05 commented Jan 20, 2024

Could you add a type check to verify that A is a quaternion algebra?

Added a check to make sure A is a quaternion algebra of the form A=(a,b)K since .discriminant() depends on this type of quaternion algebra representation - thanks for bringing this up!

Modified the error message to exclude the word rational since the base field of both quaternion algebras is only checked afterwards.

Copy link

Documentation preview for this PR (built with commit e3e69c2; changes) is ready! 🎉

Copy link
Contributor

@pjbruin pjbruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vbraun vbraun merged commit 919b021 into sagemath:develop Jan 22, 2024
19 of 20 checks passed
@S17A05 S17A05 deleted the is_isomorphic branch January 22, 2024 10:17
@S17A05 S17A05 changed the title Added is_isomorphic() for rational quaternion algebras Added .is_isomorphic for rational quaternion algebras Jan 25, 2024
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants