throw ValueError instead of TypeError when logarithm doesn't exist in AdditiveAbelianGroupWrapper #37142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But I don't have review/merge perms. |
|
@grhkm21, I've invited you to the Sage organization (and the Triage team). Once you accept, you can review PRs. |
yyyyx4
force-pushed
the
public/throw_ValueError_when_logarithm_does_not_exist
branch
from
8b38164
to
fecafde
Compare
|
Thanks, and sorry, I ripped this out of a branch with a larger set of changes and apparently forgot to run the tests again prior to making the pull request... |
...because attempting to run this with unhashable elements throws the same exception, which can cause confusion in higher-level algorithms.
yyyyx4
force-pushed
the
public/throw_ValueError_when_logarithm_does_not_exist
branch
from
fecafde
to
4d6f31b
Compare
|
Documentation preview for this PR (built with commit 4d6f31b; changes) is ready! 🎉 |
|
LGTM :D |
yyyyx4
deleted the
public/throw_ValueError_when_logarithm_does_not_exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to run the higher-level algorithms in the
additive_abelian_wrapper.pyfile on a group with unhashable elements will also throw aTypeError, which leads to very strange behavior (rather than failing with a clear error message, as it should).#sd123