Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matroid attribute girth() #37145

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add matroid attribute girth() #37145

merged 2 commits into from
Feb 2, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Jan 22, 2024

Added a function girth() to the main matroid class. This is a standard notion which corresponds to the size of the smallest circuit of the matroid. A similar notion exists for graphs.

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing; otherwise LGTM.

src/sage/matroids/matroid.pyx Outdated Show resolved Hide resolved
Copy link

Documentation preview for this PR (built with commit 58521e5; changes) is ready! 馃帀

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2024
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Added a function `girth()` to the main matroid class. This is a standard
notion which corresponds to the size of the smallest circuit of the
matroid. A similar notion exists for graphs.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 馃摑 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#37145
Reported by: gmou3
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit ebeb7a2 into sagemath:develop Feb 2, 2024
18 of 19 checks passed
@gmou3 gmou3 deleted the girth branch February 2, 2024 21:47
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants