Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in reduction of element modulo ideal in exterior algebra #37146

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Fix a bug in reduction of element modulo ideal in exterior algebra #37146

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e06400
Initial commit of fix for #37108
trevorkarn Jan 22, 2024
b1ffa01
Update doctest
trevorkarn Jan 23, 2024
7bbb66c
Documentation fix
trevorkarn Jan 24, 2024
fa766d2
Documentation enhancement
trevorkarn Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/sage/algebras/exterior_algebra_groebner.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,13 +477,32 @@ cdef class GroebnerStrategy:
0
sage: I._groebner_strategy.reduce(E.zero())
0

Check #37108 is fixed::
trevorkarn marked this conversation as resolved.
Show resolved Hide resolved

sage: E = ExteriorAlgebra(QQ, 6)
sage: E.inject_variables(verbose=False)
sage: gens = [-e0*e1*e2 + e0*e1*e5 - e0*e2*e3 - e0*e3*e5 + e1*e2*e3 + e1*e3*e5,
....: e1*e2 - e1*e5 + e2*e5,
....: e0*e2 - e0*e4 + e2*e4,
....: e3*e4 - e3*e5 + e4*e5,
....: e0*e1 - e0*e3 + e1*e3]
trevorkarn marked this conversation as resolved.
Show resolved Hide resolved
sage: I = E.ideal(gens)
sage: S = E.quo(I)
sage: I.reduce(e1*e3*e4*e5)
0
"""
if not f:
return f
# Make a copy to mutate
f = type(f)(f._parent, copy(f._monomial_coefficients))
for g in self.groebner_basis:
self.reduce_single(f, g)
was_reduced = True
while was_reduced:
was_reduced = False
for g in self.groebner_basis:
was_reduced = self.reduce_single(f, g)
if was_reduced:
break
return f

cdef bint reduce_single(self, CliffordAlgebraElement f, CliffordAlgebraElement g) except -1:
Expand Down
Loading