Fix cvxopt build with suitesparse homebrew; fixes #37149. #37161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix issue #37149.
The problem is that cvxopt doesn't build correctly when using the homebrew-provided version of SuiteSparse.
As suggested in the discussion of the issue, I added the
CVXOPT_SUITESPARSE_INC_DIR
environment variable in the.homebrew-build-env
file.This is an ugly workaround, and should probably be reported/discussed also on the cvxopt repo, since the issue seems to be that they do
#include "umfpack.h"
instead of a more proper#include "suitesparse/umfpack.h"
.Indeed, for Linux system, their
setup.py
script then has to set the include folder to bewhatever/include/suitesparse
instead of the default system one.Also, I don't have a way to check if this breaks other installations.
📝 Checklist
⌛ Dependencies