search for a pair of pre- and post-isomorphism instead of just a post-isomorphism when computing dual isogeny #37175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-isomorphism when computing dual isogeny
GiacomoPope
reviewed
Jan 29, 2024
|
Documentation preview for this PR (built with commit 42a2547; changes) is ready! 🎉 |
|
Looks good to me. |
GiacomoPope
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While computing the dual of an isogeny, the current code only searches for a post-isomorphism which gives the correct scaling factor overall. In some cases, as shown by #37168, such an isomorphism may not exist, and we additionally have to compose with a suitable pre-isomorphism.
This resolves #37168.