some pep8 fixes in rings, and activate E221 #37228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 9e7a585; changes) is ready! 馃帀 |
|
Overall, the changes are fine with me, but I am slightly worried about forcing E221 on code as there could be a good reason to have the spaces (demonstrating an alignment in, e..g, a matrix). It might not happen, but I don't want to force it when it could make the code locally harder to parse. |
|
Well, there is no such case in our code base right now. And pep008 suggest to avoid spaces for alignement: https://peps.python.org/pep-0008/#pet-peeves But if you insist, I can remove the activation. Not so important, really. https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes |
tscrim
approved these changes
Feb 6, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
This fixes all remaining pycodestyle E221 warnings in py files and
activate this check in the pycodestyle-minimal linter.
This is about `E221 multiple spaces before operator`
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37228
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all remaining pycodestyle E221 warnings in py files and activate this check in the pycodestyle-minimal linter.
This is about
E221 multiple spaces before operator馃摑 Checklist