make a category of Dedekind domains, remove code from ring.pyx #37234
Conversation
|
maybe one should make ZZ belong to this category ? |
There was a problem hiding this comment.
One tiny thing (it should be fixed more broadly though). However, I think it is a good thing to refine the category of ZZ and remove duplicate methods (these should never be a critical part of any algorithm IMO, so downgrading Cython -> Python shouldn't have any real effect...I hope).
|
It seems that ZZ prefers to inherit |
|
a real can of worms. One would like to make ZZ based on Parent, but this is not simple at all. I would rather undo the removal of these two methods in ZZ for the moment, if you agree. |
fchapoton
force-pushed
the
dedekind_domain_category
branch
from
37c4e9f
to
c85a268
Compare
|
Ah, right, categories have the lowest precedence. Yes, we can revert removing them. It was just trying to avoid some redundancies. |
fchapoton
force-pushed
the
dedekind_domain_category
branch
from
c24281c
to
8469f2c
Compare
|
ok, right. Annoying it was. Because this was informally deprecated for a long time, I have just put a minimal replacement in place. I have also (in the same commit) replaced all general imports of |
|
Documentation preview for this PR (built with commit 7b3bb5b; changes) is ready! 🎉 |
fchapoton
added
s: needs review
s: positive review
and removed
s: needs work
s: needs review
labels
…om ring.pyx
This is creating a `DedekindDomains` category and moving the associated
code from `ring.pyx` to the category.
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
URL: sagemath#37234
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
This is creating a
DedekindDomainscategory and moving the associated code fromring.pyxto the category.📝 Checklist