details in Zariski-Van-Kampen #37281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a related PR #36768 with more changes in this file and with changes in some other files. A merge? |
mantepse
reviewed
Feb 11, 2024
|
Documentation preview for this PR (built with commit bdf89ec; changes) is ready! 馃帀 |
enriqueartal
added a commit
to enriqueartal/sage
that referenced
this pull request
Feb 11, 2024
grhkm21
approved these changes
Feb 13, 2024
Comment on lines
-1318
to
1322
| if len(A1) == 0: | ||
| if not A1: | ||
| b = B.one() | ||
| else: | ||
| b = prod(A1) |
There was a problem hiding this comment.
I believe you can make this b = prod(A1, B.one()).
Comment on lines
1379
to
+1383
| br1 = B0.delta()**r * B0(prod(B0(_) for _ in br0_left[1:])) | ||
| cox = prod(F0.gens()) | ||
| U0 = [cox**q * (f0 * br1) / cox**q / f0 for f0 in F0.gens()[:-1]] | ||
| U = [tuple(sign(k1)*(abs(k1) + k) for k1 in _.Tietze()) for _ in U0] | ||
| pasos = [B.one()] + [_ for _ in reversed(L1)] | ||
| U = [tuple(sign(k1) * (abs(k1) + k) for k1 in _.Tietze()) for _ in U0] | ||
| pasos = [B.one()] + list(reversed(L1)) |
There was a problem hiding this comment.
- br1 = B0.delta()**r * B0(prod(B0(_) for _ in br0_left[1:]))
+ br1 = B0.delta()**r * prod(map(B0, br0_left[1:]), B0.one())Also, do you mind renaming _ to say br or something sensible? Variable names shouldn't start with underscores if they are used.
grhkm21
added
p: minor / 4
s: positive review
c: algebraic geometry
t: refactoring
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
Small changes in the modified files, about pep8 and ruff warnings about
code
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37281
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): grhkm21, Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
Small changes in the modified files, about pep8 and ruff warnings about
code
### 馃摑 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37281
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): grhkm21, Martin Rubey
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes in the modified files, about pep8 and ruff warnings about code
馃摑 Checklist