-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
details in Zariski-Van-Kampen #37281
Conversation
There is a related PR #36768 with more changes in this file and with changes in some other files. A merge? |
Documentation preview for this PR (built with commit bdf89ec; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since your PR focuses on details / Pythonic changes, I suggested some too, but they are optional. Otherwise, looks good to me.
if len(A1) == 0: | ||
if not A1: | ||
b = B.one() | ||
else: | ||
b = prod(A1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can make this b = prod(A1, B.one())
.
br1 = B0.delta()**r * B0(prod(B0(_) for _ in br0_left[1:])) | ||
cox = prod(F0.gens()) | ||
U0 = [cox**q * (f0 * br1) / cox**q / f0 for f0 in F0.gens()[:-1]] | ||
U = [tuple(sign(k1)*(abs(k1) + k) for k1 in _.Tietze()) for _ in U0] | ||
pasos = [B.one()] + [_ for _ in reversed(L1)] | ||
U = [tuple(sign(k1) * (abs(k1) + k) for k1 in _.Tietze()) for _ in U0] | ||
pasos = [B.one()] + list(reversed(L1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- br1 = B0.delta()**r * B0(prod(B0(_) for _ in br0_left[1:]))
+ br1 = B0.delta()**r * prod(map(B0, br0_left[1:]), B0.one())
Also, do you mind renaming _
to say br
or something sensible? Variable names shouldn't start with underscores if they are used.
Small changes in the modified files, about pep8 and ruff warnings about code ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37281 Reported by: Frédéric Chapoton Reviewer(s): grhkm21, Martin Rubey
Small changes in the modified files, about pep8 and ruff warnings about code ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37281 Reported by: Frédéric Chapoton Reviewer(s): grhkm21, Martin Rubey
Small changes in the modified files, about pep8 and ruff warnings about code
📝 Checklist