Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/pytest*: Change to standard wheel packages #37301

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Feb 12, 2024

Vote: https://groups.google.com/g/sage-devel/c/MIU-xo9b7pc
Vote (redo): https://groups.google.com/g/sage-devel/c/lPLoA7zaoyg

Fixes #31110

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 12, 2024
@mkoeppe mkoeppe force-pushed the pytest_standard branch 2 times, most recently from 7e85345 to 74e7744 Compare February 15, 2024 08:43
@mkoeppe mkoeppe marked this pull request as ready for review February 15, 2024 08:43
@mkoeppe mkoeppe changed the title build/pkgs/pytest*: Change to standard normal packages build/pkgs/pytest*: Change to standard wheel packages Feb 18, 2024
@mkoeppe mkoeppe requested a review from dimpase February 18, 2024 18:20
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 18, 2024

@dimpase May I suggest that you take the time to try out this PR? If you want to understand how a "wheel" package (https://deploy-livedoc--sagemath.netlify.app/html/en/developer/packaging#package-source-types) is installed, maybe install using ./sage -i -s pytest and look at what's happening in venv/var/tmp/sage

@dimpase
Copy link
Member

dimpase commented Feb 18, 2024

As I said, I object to endless proliferation of more and more python (wheel - in case of pure python - or source, doesn't really matter) packages in Sage. If these were pip packages it would be possible to avoid bringing 2 more dependencies into Sage

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 18, 2024

As I said, I object

We already know that.

My suggestion above is friendly guidance to a level on which a discussion makes more sense than what's currently happening in https://groups.google.com/g/sage-devel/c/5kmxaw105lg

Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit b34ee07; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pytest a standard package
2 participants