-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
use CommutativeRing in ring_extension #37316
Conversation
Documentation preview for this PR (built with commit 8de95f8; changes) is ready! 馃帀 |
Does this actually mean that inheriting from
? More precisely, I tried:
and with the new branch, the last line is (I admit that I'm not completely sure what |
yes, probably your are right. The usage of My aim for now is to keep only the bad class The change here is a step towards deprecating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Removing one of the last uses of `CommutativeAlgebra` class, towards its deprecation. Also a few pep8 fixes in the modified file. ### 馃摑 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37316 Reported by: Fr茅d茅ric Chapoton Reviewer(s): Martin Rubey
Removing one of the last uses of `CommutativeAlgebra` class, towards its deprecation. Also a few pep8 fixes in the modified file. ### 馃摑 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37316 Reported by: Fr茅d茅ric Chapoton Reviewer(s): Martin Rubey
Removing one of the last uses of
CommutativeAlgebra
class, towards its deprecation.Also a few pep8 fixes in the modified file.
馃摑 Checklist