Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup database_matroids.py tests #37338

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Feb 14, 2024

I strategically recast a few matroids in database_matroids.py to CircuitsMatroids (given #37148).
On my old laptop, this results in a x5 speedup in the testing of the file, and in a x2 speedup in the testing of the whole of the matroids module (saving ~1m).

Copy link

Documentation preview for this PR (built with commit 31d6130; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit ec7b486 into sagemath:develop Feb 25, 2024
19 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
@gmou3 gmou3 deleted the database_matroids branch April 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants