Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow submodule construction of a free module over a ring #37354

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Allow submodule construction of a free module over a ring #37354

merged 2 commits into from
Feb 25, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Feb 15, 2024 •
edited

This fails

sage: R.<x,y> = QQ[]
sage: S = R.quotient([x*y])
sage: M = FreeModule(S, 2)
sage: M.zero_submodule()
...
TypeError: ambient (=Ambient free module of rank 2 over Quotient of Multivariate Polynomial Ring in x, y over Rational Field by the ideal (x*y)) must be ambient or a quotient

We fix this by removing unnecessary restriction on modules over rings.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title p/zero submodule Allow submodule construction of a free module over a ring (not necessarily a domain) Feb 15, 2024
@kwankyu kwankyu changed the title Allow submodule construction of a free module over a ring (not necessarily a domain) Allow submodule construction of a free module over a ring Feb 15, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 300c3a3; changes) is ready! 🎉

tscrim
tscrim approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 20, 2024

Thank you!

@vbraun vbraun merged commit 2180122 into sagemath:develop Feb 25, 2024
17 of 23 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: algebra t: enhancement
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwankyu @tscrim @vbraun @mkoeppe