Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less usage of method .is_commutative #37355

Merged
merged 1 commit into from
Feb 25, 2024
Merged

less usage of method .is_commutative #37355

merged 1 commit into from
Feb 25, 2024

Conversation

fchapoton
Copy link
Contributor

changing a few calls of R.is_commutative() for rings, in favour of the syntax R in CommutativeRings()

馃摑 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 85e1310; changes) is ready! 馃帀

tscrim
tscrim approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit f5983a3 into sagemath:develop Feb 25, 2024
16 of 22 checks passed
@fchapoton fchapoton deleted the less_is_commutative branch February 25, 2024 12:28
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: commutative algebra
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe