improve random sampling of quotient-ring elements #37367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 5c1309c; changes) is ready! 🎉 |
GiacomoPope
approved these changes
Feb 16, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
Currently, random sampling in generic quotient rings is restricted to a
very small (and special) subset of the elements:
```sage
sage: R.<x,y> = QQ[]
sage: S = R.quotient([x^3, y^2])
sage: {S.random_element() for _ in range(999)}
{-2, -1, 0, 1, 2}
```
In this patch we add an implementation of `.random_element()` which
simply calls the `.random_element()` method of the cover ring and maps
the result to the quotient. This is still far from perfect for many
kinds of quotient rings, but it's definitely an improvement compared to
the current behavior.
URL: sagemath#37367
Reported by: Lorenz Panny
Reviewer(s): Giacomo Pope
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
Currently, random sampling in generic quotient rings is restricted to a
very small (and special) subset of the elements:
```sage
sage: R.<x,y> = QQ[]
sage: S = R.quotient([x^3, y^2])
sage: {S.random_element() for _ in range(999)}
{-2, -1, 0, 1, 2}
```
In this patch we add an implementation of `.random_element()` which
simply calls the `.random_element()` method of the cover ring and maps
the result to the quotient. This is still far from perfect for many
kinds of quotient rings, but it's definitely an improvement compared to
the current behavior.
URL: sagemath#37367
Reported by: Lorenz Panny
Reviewer(s): Giacomo Pope
|
It would be good to also pass options along. |
|
Good point, but it looks like @vbraun is already merging this — is it okay to still change the branch now? |
|
Hmmm….possibly no. Let’s just make another PR, and cc me for the review. |
yyyyx4
deleted the
public/improve_random_sampling_in_generic_quotient_rings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, random sampling in generic quotient rings is restricted to a very small (and special) subset of the elements:
In this patch we add an implementation of
.random_element()which simply calls the.random_element()method of the cover ring and maps the result to the quotient. This is still far from perfect for many kinds of quotient rings, but it's definitely an improvement compared to the current behavior.