Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and regression in performance of any_root() #37443

Merged
merged 22 commits into from
Feb 29, 2024
Merged

Fix bugs and regression in performance of any_root() #37443

merged 22 commits into from
Feb 29, 2024

Commits on Feb 23, 2024

  1. Try and speed up any_root

    @GiacomoPope
    GiacomoPope committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    732d3b3 View commit details
    Browse the repository at this point in the history

  2. Replace comment

    @GiacomoPope
    GiacomoPope committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    38e93a5 View commit details
    Browse the repository at this point in the history

  3. linter

    @GiacomoPope
    GiacomoPope committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e3b12dd View commit details
    Browse the repository at this point in the history

  4. Slightly more intelligent way to find correct degree irr

    @GiacomoPope
    GiacomoPope committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2569e61 View commit details
    Browse the repository at this point in the history

  5. Use f.roots() instead of f.any_root() when working with extensions

    @GiacomoPope
    GiacomoPope committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    09bcfdd View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. fix issue 37445

    @GiacomoPope
    GiacomoPope committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    2ce4ddd View commit details
    Browse the repository at this point in the history

  2. review comments

    @GiacomoPope
    GiacomoPope committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7a61d6a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: grhkm21 <83517584+grhkm21@users.noreply.github.com>
    @GiacomoPope @grhkm21
    GiacomoPope and grhkm21 committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    a7bdc3e View commit details
    Browse the repository at this point in the history

  4. Better error handling

    @GiacomoPope
    GiacomoPope committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    030ce6d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix_any_root_extension' of https://github.com/GiacomoPo… 

    …pe/sage into fix_any_root_extension
    @GiacomoPope
    GiacomoPope committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c8e7464 View commit details
    Browse the repository at this point in the history

  6. Make any_root deterministic for char 0 fields

    @GiacomoPope
    GiacomoPope committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    db3ecc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Fix sagemath#37471

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    7052c25 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
    @GiacomoPope @tscrim
    GiacomoPope and tscrim committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    a6e928e View commit details
    Browse the repository at this point in the history

  3. Add doctest for issue sagemath#37417

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0aea29c View commit details
    Browse the repository at this point in the history

  4. Add docstring about determinism of roots

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f8bc02f View commit details
    Browse the repository at this point in the history

  5. Update src/sage/schemes/elliptic_curves/cm.py 

    Co-authored-by: grhkm21 <83517584+grhkm21@users.noreply.github.com>
    @GiacomoPope @grhkm21
    GiacomoPope and grhkm21 committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    5c82b47 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into fix_any_root_extension

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    055244d View commit details
    Browse the repository at this point in the history

  7. Wrap to 80 and add code syntax highlighting

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6d767c3 View commit details
    Browse the repository at this point in the history

  8. rename assume_distinct_deg to assume_equal_deg

    @GiacomoPope
    GiacomoPope committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    ee36eb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. More detailed comment

    @GiacomoPope
    GiacomoPope committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    dd56924 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. More detailed NOTE for any_root()

    @GiacomoPope
    GiacomoPope committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b161117 View commit details
    Browse the repository at this point in the history

  2. More detailed NOTE for any_root()

    @GiacomoPope
    GiacomoPope committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b8da002 View commit details
    Browse the repository at this point in the history