New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage --package
, sage-get-system-packages
: Support PURLs pkg:pypi/DISTRO-NAME
, obtain dependencies of wheels from PyPI
#37500
Conversation
7f2157c
to
74a3708
Compare
sage --package
, sage-get-system-packages
: Support PURLs pkg:pypi/DISTRO-NAME
sage --package
, sage-get-system-packages
: Support PURLs pkg:pypi/DISTRO-NAME
, obtain dependencies of wheels from PyPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really qualified to review most of this PR, but I do see some vestigial trace of the code that I provided, and it looks like the overall scheme makes sense. More automation of the process of maintaining the boilerplate in the file-based spkg database seems like a very useful and important contribution.
e2d9909
to
9fe4529
Compare
9f599b9
to
9008916
Compare
9008916
to
34dfbad
Compare
Documentation preview for this PR (built with commit 06c3f90; changes) is ready! 🎉 |
34dfbad
to
975d3e3
Compare
Otherwise, lgtm. It works well. |
…RL in sage --package properties
…ls, use pip instead of PYTHON_TOOLCHAIN
…w generates dependencies for wheels
Tentative resolve of merge conflict caused by #36982. |
Setting back to positive review |
We make it possible to refer to Python packages via their PURL (see draft PEP 725) instead of their SPKG name.
For now a string of the form
pkg:pypi/DISTRO-NAME
is simply a nickname for the (unique) SPKG that has DISTRO-NAME in theirversion_requirements.txt
orrequirements.txt
. The scheme can also be omitted:pypi/DISTRO-NAME
also works. And we also mappkg:generic/PACKAGE-NAME
toPACKAGE_NAME
.Based on code by @culler,
sage --package create --pypi
now also fillsdependencies
from the PyPI metadata of wheel packages. When some of the Python dependencies obtained in this way do not have SPKGs yet, they are also automatically created.pypi/
, rename to match their PyPI name #31136.PipPackageSystem
: If EXTERNALLY-MANAGED, issue venv instructions; supportFeature(spkg='pkg:pypi/DISTRO-NAME')
#37250.📝 Checklist
⌛ Dependencies