Implement the hypercenter and upper central series for finite dimensional Lie algebras #37693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mkoeppe
reviewed
Apr 3, 2024
mkoeppe
reviewed
Apr 3, 2024
src/sage/categories/examples/finite_dimensional_lie_algebras_with_basis.py
Outdated
Show resolved
Hide resolved
mkoeppe
reviewed
Apr 3, 2024
src/sage/categories/examples/finite_dimensional_lie_algebras_with_basis.py
Outdated
Show resolved
Hide resolved
mkoeppe
reviewed
Apr 3, 2024
src/sage/categories/finite_dimensional_lie_algebras_with_basis.py
Outdated
Show resolved
Hide resolved
tscrim
force-pushed
the
lie_algebras/hypercenter
branch
from
02b2233
to
2d446eb
Compare
|
I've added all of the suggested whitespace. |
mkoeppe
reviewed
Apr 8, 2024
Comment on lines
221
to
225
| try: | ||
| amb_names = dict(zip(sorted_indices, ambient.variable_names())) | ||
| names = [amb_names[i] for i in index_set] | ||
| except ValueError: # ambient has not assigned variable names | ||
| pass |
There was a problem hiding this comment.
I'd suggest to rewrite it as try... except... else, which makes it clearer which of the lines is expected to raise the exception
There was a problem hiding this comment.
I instead just examined the _names attribute and avoided using try-except to control programming flow.
tscrim
force-pushed
the
lie_algebras/hypercenter
branch
from
2d446eb
to
d821fae
Compare
|
Documentation preview for this PR (built with commit 4fa759a; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
…for finite dimensional Lie algebras
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
We implement the upper central series and hypercenter of a finite
dimensional Lie algebra.
As part of the testing, we found improvements could be made to the
generic example (needed so the example would work with these tests): We
moved the `reduce()` method up to the category. Implemented methods
expected for the subalgebras. Better input verification. Elements are
now hashable. We had to work around the fact that `lift()` is serving
multiple roles as to the UEA and to the ambient space for a Lie
subalgebra. This functionality needs to be divided (I take full
responsibility for this bad design) by renaming `lift` to something for
the UEA map, but this is a significant change that should be done on a
followup PR.
We also fixed some bugs and improved efficiency with changing vectors
into Lie algebra elements.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37693
Reported by: Travis Scrimshaw
Reviewer(s): Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the upper central series and hypercenter of a finite dimensional Lie algebra.
As part of the testing, we found improvements could be made to the generic example (needed so the example would work with these tests): We moved the
reduce()method up to the category. Implemented methods expected for the subalgebras. Better input verification. Elements are now hashable. We had to work around the fact thatlift()is serving multiple roles as to the UEA and to the ambient space for a Lie subalgebra. This functionality needs to be divided (I take full responsibility for this bad design) by renamingliftto something for the UEA map, but this is a significant change that should be done on a followup PR.We also fixed some bugs and improved efficiency with changing vectors into Lie algebra elements.
📝 Checklist
⌛ Dependencies