Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the category of quasi-modular form rings #37797

Merged
merged 2 commits into from May 2, 2024
Merged

fix the category of quasi-modular form rings #37797

merged 2 commits into from May 2, 2024

Conversation

fchapoton
Copy link
Contributor

fir the category of some rings of quasi-modular forms

See https://ask.sagemath.org/question/76909/

馃摑 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

S17A05
S17A05 reviewed Apr 13, 2024
View reviewed changes
Copy link
Contributor

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small typos in the comments

src/sage/modular/quasimodform/ring.py Outdated Show resolved Hide resolved
src/sage/modular/quasimodform/ring.py Outdated Show resolved Hide resolved
S17A05
S17A05 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming there are no issues with CI.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit f230dbb; changes) is ready! 馃帀
This preview will update shortly after each push to this PR.

seewoo5
seewoo5 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@seewoo5 seewoo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your comment to my question on the forum - Thank you!

@fchapoton
Copy link
Contributor Author

I allow myself to set this to positive review.

@DavidAyotte
Copy link
Member

Thank you Fr茅d茅ric for fixing this !

@DavidAyotte DavidAyotte mentioned this pull request Apr 17, 2024
Open
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
sagemathgh-37797: fix the category of quasi-modular form rings
7775b78 
    
fir the category of some rings of quasi-modular forms


See https://ask.sagemath.org/question/76909/

### 馃摑 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#37797
Reported by: Fr茅d茅ric Chapoton
Reviewer(s): Sebastian A. Spindler, Seewoo Lee
@vbraun vbraun merged commit ac8792f into sagemath:develop May 2, 2024
14 of 15 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seewoo5 seewoo5 seewoo5 approved these changes

@S17A05 S17A05 S17A05 approved these changes

Assignees
No one assigned
Labels
c: modular forms t: bug
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fchapoton @DavidAyotte @seewoo5 @S17A05 @vbraun @mkoeppe