Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiniteRankFreeModuleMorphism.display: Show matrix decorated with basis element names #37825

Merged
merged 3 commits into from May 2, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Apr 18, 2024

FiniteRankFreeModuleMorphism gets a new method display, which shows the matrix with rows and columns decorated with the names of the basis elements like \bordermatrix.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 18, 2024

Documentation preview for this PR (built with commit db4e675; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 18, 2024

I'm glad you like it! Thanks for the review.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
… decorated with basis element names

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

`FiniteRankFreeModuleMorphism` gets a new method `display`, which shows
the matrix with rows and columns decorated with the names of the basis
elements like `\bordermatrix`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37825
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon
@vbraun vbraun merged commit 698774f into sagemath:develop May 2, 2024
14 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants