Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gap: don't use deprecated LaTeX() and LaTeXObj() #37883

Merged
merged 1 commit into from
May 2, 2024

Conversation

tornaria
Copy link
Contributor

These functions were removed in 4.13, but they weren't very good anyway.

This PR replaces its usage. It should work fine on old gap so this can be merged just fine.

馃摑 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

These functions were removed in 4.13.
Copy link

Documentation preview for this PR (built with commit da9305a; changes) is ready! 馃帀
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
These functions were removed in 4.13, but they weren't very good anyway.

This PR replaces its usage. It should work fine on old gap so this can
be merged just fine.

### 馃摑 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#37883
Reported by: Gonzalo Tornar铆a
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit a1354a7 into sagemath:develop May 2, 2024
18 of 19 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
@tornaria tornaria deleted the gap-latex branch May 3, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants