Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order computation for linear groups GL(n, R) and SL(n, R) #37980

Merged
merged 3 commits into from
May 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 81 additions & 9 deletions src/sage/groups/matrix_gps/linear.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
from sage.misc.latex import latex
from sage.misc.misc_c import prod
from sage.rings.infinity import Infinity
from sage.rings.integer_ring import ZZ
from sage.rings.finite_rings.integer_mod_ring import Integers


###############################################################################
Expand Down Expand Up @@ -311,7 +313,7 @@ def _check_matrix(self, x, *args):
raise TypeError('matrix must non-zero determinant')

def order(self):
"""
r"""
Return the order of ``self``.

EXAMPLES::
Expand All @@ -320,6 +322,23 @@ def order(self):
sage: G.order()
372000

The order computation also works over the base rings `\ZZ/n\ZZ`::

sage: GL(4, Integers(15)).order()
2815842631680000000

sage: SL(4, Integers(15)).order()
351980328960000000

Arbitrary base rings are currently not fully supported::

sage: R.<x> = PolynomialRing(GF(7))
sage: S = R.quotient(x^2 + 5)
sage: GL(2, S).order()
Traceback (most recent call last):
...
NotImplementedError: order computation of linear groups not fully supported for arbitrary base rings

TESTS:

Check if :issue:`36876` is fixed::
Expand All @@ -340,18 +359,71 @@ def order(self):
True
sage: S.order()
117600
"""
n = self.degree()

if self.base_ring().is_finite():
q = self.base_ring().order()
Check if :issue:`37934` is fixed::

sage: GL(2, Integers(4)).order()
96

sage: GL(2, Integers(1)).order()
1

sage: GL(1, ZZ).order()
2
"""
def order_over_finite_field(q, n, special):
S17A05 marked this conversation as resolved.
Show resolved Hide resolved
ord = prod(q**n - q**i for i in range(n))
if self._special:
return ord / (q-1)
if special:
ord = ord // (q-1)
S17A05 marked this conversation as resolved.
Show resolved Hide resolved
return ord

if self._special and n == 1:
n = self.degree()
R = self.base_ring()

if R.is_finite():
q = R.order()

if q == 1:
return 1
S17A05 marked this conversation as resolved.
Show resolved Hide resolved

if R.is_field():
return order_over_finite_field(q, n, self._special)
S17A05 marked this conversation as resolved.
Show resolved Hide resolved

if R == Integers(q):
ord = 1

# By the Chinese remainder theorem we need to build the product
# over the orders of GL(n, ZZ/p^e ZZ) (or SL) for all prime
# powers in the factorization of q
for (p,e) in q.factor():
ord_base = order_over_finite_field(p, n, self._special)
S17A05 marked this conversation as resolved.
Show resolved Hide resolved

if not self._special:
ord *= p**((e-1)*n**2) * ord_base

# We apply |SL(n, R)| = |GL(n, R)| / euler_phi(q), but since we
# already iterate over the prime factorization of q, we divide
# out euler_phi(q) iteratively. Noting that (p-1) is already
# handled in the call to order_over_finite_field, we only
# need to remove p^(e-1) compared to the above formula
else:
ord *= p**((e-1)*(n**2 - 1)) * ord_base
S17A05 marked this conversation as resolved.
Show resolved Hide resolved

return ord

raise NotImplementedError("order computation of linear groups not "
"fully supported for arbitrary base rings")

if n > 1 or (R.is_field() and not self._special):
return Infinity

if self._special:
return 1
S17A05 marked this conversation as resolved.
Show resolved Hide resolved
return Infinity

if R == ZZ:
return 2
S17A05 marked this conversation as resolved.
Show resolved Hide resolved

raise NotImplementedError("order computation of linear groups not "
"fully supported for arbitrary base rings")

cardinality = order
Loading