Add Oriented Matroids Package #38024
Conversation
|
The |
|
Documentation preview for this PR (built with commit eb1cc24; changes) is ready! 🎉 |
Don't worry about that, it is some error of the tester. |
tscrim
added
t: enhancement
s: needs review
and removed
v: large
s: needs review
labels
SageMath version 10.4.beta7, Release Date: 2024-05-25
| """ | ||
| if hasattr(self, "_circuits"): | ||
| return self._circuits | ||
| raise NotImplementedError("Circuits not implemented") |
There was a problem hiding this comment.
I would recommend all Error messages to start uncapitalized and end without a dot.
| \mathcal{C} / A = \left\{ X\mid_{E \backslash A} : X \in \mathcal{C} \text{ and} A \subseteq X^0 \right\} | ||
|
|
||
| """ | ||
| # sage: from sage.matroids.oriented_matroids.oriented_matroid import OrientedMatroid |
There was a problem hiding this comment.
Do something with this commented code?
|
|
||
| AUTHORS: | ||
|
|
||
| - Aram Dermenjian (): initial version |
There was a problem hiding this comment.
Need to add date or complete/delete file.
Co-authored-by: gmou3 <32706872+gmou3@users.noreply.github.com>
|
@gmou3 I've gone ahead and fixed the things you wanted. |
|
Thanks. I had opened a PR a while ago with some formatting recommendations. Please have a look and merge or close it please. |
Some formatting recommendations
|
I hadn't noticed the pull request for some reason. I've added your changes as well and double checked things work nicely. Thanks for that. |
|
Cool. Personally, I'll need some time to review the more essential parts, while learning about oriented matroids. |
No worries. Take your time =) If there's anything I can do to help, let me know. |
This pull request merges the Oriented Matroids package that I developed (see https://github.com/thecaligarmo/oriented_matroids) into Sage so that others may develop directly into it rather than relying solely on myself.
This package should resolve ticket #18703 and in addition, my package should be removed from #31164 as this pull request will put Oriented Matroids directly into Sage rather than requiring a package.
If there are any changes needing to be made, just let me know and we can go from there.
📝 Checklist
⌛ Dependencies