Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign names to constructed Hadamard matrices #38042

Merged
merged 5 commits into from
May 25, 2024
Merged

assign names to constructed Hadamard matrices #38042

merged 5 commits into from
May 25, 2024

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented May 20, 2024

Hadamard and skew-Hadamard matrix generators are not telling you anything about the matrix you're getting.
This PR is an attempt to get this to work a bit better.

馃摑 Checklist

  • [X ] The title is concise and informative.
  • [ X] The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@dimpase dimpase requested a review from MatteoCati May 20, 2024 22:58
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited

Documentation preview for this PR (built with commit ee798a3; changes) is ready! 馃帀
This preview will update shortly after each push to this PR.

@dimpase dimpase requested a review from dcoudert May 21, 2024 21:17
dcoudert
dcoudert suggested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

src/sage/combinat/matrices/hadamard_matrix.py Show resolved Hide resolved
@dimpase
Copy link
Member Author

dimpase commented May 22, 2024

@MatteoCati - if you have time, until 28 May I'm revising the paper in dimpase/hadamard_sage (branch paper_specmats), have a look.
main.pdf

@dimpase
Copy link
Member Author

dimpase commented May 23, 2024

@dcoudert - positive review?

dcoudert
dcoudert approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 001b8fb into sagemath:develop May 25, 2024
21 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe left review comments

@dcoudert dcoudert dcoudert approved these changes

@MatteoCati MatteoCati MatteoCati approved these changes

Assignees
No one assigned
Labels
c: combinatorics v: moderate
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dimpase @mkoeppe @dcoudert @MatteoCati @vbraun