Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong urls in changes.html #38046

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix wrong urls in changes.html #38046

merged 1 commit into from
May 25, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented May 21, 2024 •
edited
Loading

Once again, we fix changes.html, currently broken in every PR. For example, follow #38041 (comment)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Do not add html to form path Fix wrong urls in changes.html May 21, 2024
@kwankyu kwankyu requested a review from mkoeppe May 21, 2024 13:48
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit d484ac0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Member

mkoeppe commented May 21, 2024

Thanks for the fix.
Did I break this?

@mkoeppe mkoeppe added s: positive review p: CI Fix merged before running CI tests and removed s: needs review labels May 21, 2024
@kwankyu
Copy link
Collaborator Author

kwankyu commented May 22, 2024 •
edited
Loading

Perhaps, when you made changes to how doc diffs are made... As far as I remember,

It got broken once, and to fix it, I inserted path = 'html/' + doc.

It is broken once again, and I am reverting the previous fix by path = doc.

Now all looks good :-)

@vbraun vbraun merged commit c2b63fc into sagemath:develop May 25, 2024
21 of 22 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe Awaiting requested review from mkoeppe

Assignees
No one assigned
Labels
p: CI Fix merged before running CI tests p: critical / 2 v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwankyu @mkoeppe @vbraun