Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy built documentation to GitHub gh-pages from Travis CI #8

Merged
merged 10 commits into from
May 5, 2017

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jan 18, 2017

Added a script and instructions for this.
Result can be seen here: https://mkoeppe.github.io/sage_sample/doc/html/

@nthiery
Copy link
Collaborator

nthiery commented May 4, 2017

Oops, I overlooked that pull request. Sorry Matthias! I went through it, and it sounds very reasonable.
Two questions and one obvious comment:

  • This adds some non trivial boilerplate. Do you foresee (in the long run) a way to factor out this boiler plate in e.g. sage-package?
  • Would we want the doc to be available at XXX/sage_sample/ rather than XXX/sage_sample/doc/html?
  • When time will come for a cookie cutter, we should automatize there the stuff from the README.

Other than that, any comment anyone, or should I just clic merge?

@nthiery nthiery requested review from embray and nthiery May 4, 2017 14:11
@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

This adds some non trivial boilerplate. Do you foresee (in the long run) a way to factor out this boiler plate in e.g. sage-package?

Not sure about this. Perhaps .travis-deploy-doc.sh could become a script in sage-package at some point. But it is quite possible that users will have to edit this script to customize it.

Would we want the doc to be available at XXX/sage_sample/ rather than XXX/sage_sample/doc/html?

I would rather imagine that users have some hand-written HTML, such as a project home page, in XXX/sage_sample/, which would link to doc/html.

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017 via email

.travis.yml Outdated
@@ -5,7 +5,7 @@
language: python
matrix:
include:
- env: CACHE_NAME=7.6 DEPLOY_DOC_FROM_BRANCH=master DEPLOY_DOC_TO_REPOSITORY=mkoeppe/sage_sample DEPLOY_DOC_TO_DIRECTORY=doc/html SAGE_SERVER=http://mirrors.xmission.com/sage/ SAGE_IMAGE=linux/64bit/sage-7.6-Ubuntu_12.04-x86_64.tar.bz2
- env: CACHE_NAME=7.6 DEPLOY_DOC_FROM_BRANCH=master DEPLOY_DOC_TO_REPOSITORY=mkoeppe/sage_sample DEPLOY_DOC_TO_DIRECTORY=/ SAGE_SERVER=http://mirrors.xmission.com/sage/ SAGE_IMAGE=linux/64bit/sage-7.6-Ubuntu_12.04-x86_64.tar.bz2
- env: CACHE_NAME=7.5.1 SAGE_SERVER=http://mirrors.xmission.com/sage/ SAGE_IMAGE=linux/64bit/sage-7.5.1-Ubuntu_12.04-x86_64.tar.bz2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkoeppe -> sagemath?
Is there a way to avoid naming the repository here? Just to remove one spot where the package authors has to do customization.

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017

Up to the comment I left in the diff, this is looking good, and I would be up pressing "merge". Comment anyone?

@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

How about turning on Travis CI for this repository?

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017 via email

@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

Sadly people keep deleting old binary distributions from the Sage servers -- so it's not possible any more to test a user package against old distributions. 7.1–7.4 are gone now. I'm adjusting the list of builds...

@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

I think the Travis CI will be activated if you make a single commit to one of the repository's branches now.

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017

Trivial commit pushed on mater. We probably will want to add relevant badges in the README.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

I still only see "This is not an active repository" at https://travis-ci.org/sagemath/sage_sample/ ...

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017

It's active now :-)

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017

And failing, but that's just because that it's still using the old Sage versions that you updated in that PR.

@nthiery
Copy link
Collaborator

nthiery commented May 5, 2017

Allright, that looks good, let's move on. Thank you Matthias!

@nthiery nthiery merged commit 2a390b5 into sagemath:master May 5, 2017
@mkoeppe
Copy link
Member Author

mkoeppe commented May 5, 2017

Now it would make sense to follow the instructions in README and set up the cryptographic key so that deployment works... This is the only thing that's missing for a passing Travis CI build ... https://travis-ci.org/sagemath/sage_sample/jobs/229296891

@nthiery
Copy link
Collaborator

nthiery commented May 6, 2017

Done. Well at least I think. However .travis-deploy-doc.sh hangs asking for a passphrase, when I thought I set no passphrase when defining the key. Any clue?
https://travis-ci.org/sagemath/sage_sample/jobs/229341998

@embray
Copy link

embray commented May 9, 2017

The deploy key stuff is new to me. In the past, for deployment via Travis, I've used a GitHub token (encrypted in a 'secure' environment variable in the .travis.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants