Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

update instructions for modifying sagenb in HACKING.rst #218

Merged
merged 3 commits into from
Sep 16, 2014

Conversation

ppurka
Copy link
Member

@ppurka ppurka commented Aug 30, 2014

This updates HACKING.rst. will open an issue in trac to update the documentation inside sage. This is also towards fixing #203

@ppurka
Copy link
Member Author

ppurka commented Aug 30, 2014

Remaining documentation is in http://trac.sagemath.org/ticket/16911

@kcrisman
Copy link
Member

kcrisman commented Sep 8, 2014

Hi! The only truly substantive change seems to be

cd SAGE_ROOT/local/lib/python/site-packages/sagenb-*

which is of course needed. I felt like there must be more to it than this, though? Is the whole setup develop line still needed? I haven't been doing that, maybe that is a bad thing (though things still seem to work)...

@ppurka
Copy link
Member Author

ppurka commented Sep 9, 2014

I think setup develop step is still needed for someone who has not installed sagenb before. It installs the dependencies for sagenb. In fact, it might still be needed if someday sagenb happens to depend on a newer version of some dependency.

@kcrisman
Copy link
Member

You mean for someone who has not installed Sage and is trying to just install sagenb, right? I assume that the setup develop part was already done with Sage itself. The new dependencies makes sense.

@ppurka
Copy link
Member Author

ppurka commented Sep 14, 2014

Hmm... can someone review this quickly? It is only documentation. I can then package this and update the sagenb package in trac. Hopefully all teh fixes since the last release will make it to sage-6.4

@kcrisman
Copy link
Member

I don't have any problem with this except I just don't have time to set up a whole new Sage build without sagenb somehow to make sure that setup develop is necessary. But I suppose it doesn't hurt? Otherwise this is mostly cosmetic, the substantive change is correct. Certainly it's better than the current situation!

kcrisman added a commit that referenced this pull request Sep 16, 2014
update instructions for modifying sagenb in HACKING.rst
@kcrisman kcrisman merged commit aea94ee into sagemath:master Sep 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants