This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Add deprecation warning #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokau
force-pushed
the
deprecation-warning
branch
from
56cafe5
to
12ee529
Compare
timokau
force-pushed
the
deprecation-warning
branch
from
12ee529
to
d799f48
Compare
|
Ping |
|
I thought that you were going to change the message? |
|
I did change it to
As discussed or did I misunderstand something? |
|
This one seems okay, though perhaps the mo files need to be regenerated and/or other translations ... but those hardly are a stumbling block to merging. I am not able to actually test it builds but assuming yes this should be fine. |
Merged
dimpase
reviewed
Oct 17, 2018
|
Because they reference line numbers in a file where I added a line. IIRC I manually corrected those. |
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://trac.sagemath.org/ticket/25852. I'm unsure how the localization and templating works. Am I doing this right?