Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3678 and memoize user data computation #3684

Merged
merged 5 commits into from Mar 13, 2019
Merged

Fix #3678 and memoize user data computation #3684

merged 5 commits into from Mar 13, 2019

Conversation

johnjeng
Copy link
Contributor

Description

Add a simple memoization method so that mentions data is only recomputed when users on the project changes or when the entire chatroom is rendered.

The latter could be removed but it turns out my store memoization method is broken. Sooo I'm going to look into that after this.

In any case, this memoization method is really easy to follow.

Also fixes #3678

Testing Steps

  1. Open a project with 2 users
  2. Have one user invite additional users while the other uses mentions. The list should update.
  3. Check that styling hasn't regressed

Relevant Issues

#3678

Checklist:

  • No debugging console.log messages.
  • All new code is actually used.
  • Non-obvious code has some sort of comments.

Front end:

  • Restart at least one project and check its ~/.smc/local_hub/local_hub.log
  • Completely restart Webpack with ./w in /src
  • Completely restart the hub by killing and restarting ./start_hub.py in /src/dev/project
  • Screenshots if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants