-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout cannot be smaller than 1 second #10
Comments
Hi! I tried to reproduce it like this 57e3f9a but it does work for me. Do you have a test case I can try? |
Hi, I am using pycares to create a |
Thanks for the test case! It did help me catch the bug, it's now fixed in master :-) As a side note, you may want to remove this if check here: https://gist.github.com/pyrocat101/2f1bb9fd1a864feda0f4#file-getaddrinfo-py-L17 doing a select for 0.0 seconds is perfectly fine, and you already checked above that there are sockets to be polled. |
Thank you! |
I'll make a release with these fixes somewhere this week. |
If timeout passed to Channel constructor is smaller than 1.0, operations like
gethostbyname
would immediately timeout.The text was updated successfully, but these errors were encountered: