Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c-ares to 1.24 #193

Closed
kitterma opened this issue Jan 2, 2024 · 2 comments
Closed

Update c-ares to 1.24 #193

kitterma opened this issue Jan 2, 2024 · 2 comments

Comments

@kitterma
Copy link
Contributor

kitterma commented Jan 2, 2024

There's only one test result affected by using the newer c-ares. see below for a patch to fix this to an issue. I'm providing it as an issue rather than submitting a PR since this needs to be done in tandem with updating the vendored c-ares. Let me know if you'd prefer a PR.

diff --git a/tests/test_all.py b/tests/test_all.py
index 3538823..355c892 100755
--- a/tests/test_all.py
+++ b/tests/test_all.py
@@ -569,7 +569,7 @@ class DNSTest(unittest.TestCase):
         # try encoding it as utf-8
         self.channel.query(host.encode(), pycares.QUERY_TYPE_A, cb)
         self.wait()
-        self.assertEqual(self.errorno, pycares.errno.ARES_ENOTFOUND)
+        self.assertEqual(self.errorno, pycares.errno.ARES_EBADNAME)
         self.assertEqual(self.result, None)
         # use it as is (it's IDNA encoded internally)
         self.channel.query(host, pycares.QUERY_TYPE_A, cb)

Scott K

@saghul
Copy link
Owner

saghul commented Jan 2, 2024

Do send a PR please, thank you!

@mberdyshev
Copy link

The PR should be closed then

@saghul saghul closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants