Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in test_query_txt_bytes1 #66

Closed
gvanem opened this issue Jun 7, 2018 · 3 comments
Closed

Failure in test_query_txt_bytes1 #66

gvanem opened this issue Jun 7, 2018 · 3 comments

Comments

@gvanem
Copy link

gvanem commented Jun 7, 2018

The test/test.py fails on test_query_txt_bytes1 since the domain like.com.ca does not longer exists:

FAIL: test_query_txt_bytes1 (__main__.DNSTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "F:\MingW32\src\inet\DNS\c-ares\PyCares\tests\tests.py", line 206, in test_query_txt_bytes1
    self.assertEqual(self.errorno, None)
AssertionError: 12 != None

12 == ARES_ETIMEOUT.
But changing it to like.com, all seems okay:

--- a/tests/tests.py 2017-11-16 21:09:56
+++ b/tests/tests.py 2018-06-07 16:23:10
@@ -201,7 +201,7 @@
         self.result, self.errorno = None, None
         def cb(result, errorno):
             self.result, self.errorno = result, errorno
-        self.channel.query('like.com.sa', pycares.QUERY_TYPE_TXT, cb)
+        self.channel.query('like.com', pycares.QUERY_TYPE_TXT, cb)
         self.wait()
         self.assertEqual(self.errorno, None)
@0mp
Copy link
Contributor

0mp commented Dec 27, 2018

I can confirm that the test fails. I'm testing on FreeBSD 11.2.

@saghul
Copy link
Owner

saghul commented Dec 27, 2018

Care to send a PR? I'm a bit busy these days, sorry..

@0mp
Copy link
Contributor

0mp commented Dec 28, 2018

I think it was fixed in 03e9320

@saghul saghul closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants