stream.c assert "suggested_size <= sizeof(slab)" run on windows

[richmonkey]

No description provided.

[richmonkey]

I suggest erase the assert

[saghul]

Asserts are there for a reason. What is the value of suggested_size, when it blows up?

[richmonkey]

More than 10 people run the app, i can't catch the exact assert backstrace

[saghul]

Well, I don't like to blindly change the code before understanding what is going on, it could be a side effect and removing that assert would mask a bigger issue.

[saghul]

I see a single code path which uses a variable for the suggested size, I'll investigate later today.

[saghul]

I checked with the libuv guys and under certain conditions the value can get bigger on Windows, so I removed the assert. The buffer is capped at 64K, but that's fine because libuv deals with it properly.

Thanks for the report!

[richmonkey]

TCP or PIPE ? or both? can you give me a link that talk about the problem ?

[saghul]

Both TCP and Pipe handles use on_stream_alloc, so the change applies to both. This is the code path that could lead to a big suggested_size: https://github.com/joyent/libuv/blob/master/src/win/pipe.c#L1374