Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout background image / Question #18

Closed
adalidortiz opened this issue Mar 13, 2020 · 6 comments
Closed

Layout background image / Question #18

adalidortiz opened this issue Mar 13, 2020 · 6 comments
Assignees
Labels

Comments

@adalidortiz
Copy link

Garlic Player support layout background image? Any help about it?

Saludos .

@sagiadinos
Copy link
Owner

sagiadinos commented Mar 16, 2020

Holá,

There is no support for background images, currently. One possible workaround is: you can try to use two overlapping regions and set the "background" image in the back region as infinity loop.

I implemented backgroundImage and backgroundRepeat functionality for regions yesterday, but the solution is unsatisfying so I did not commit the code.

The problem is that QWidget supports only local files as backgrounds. So background image must downloaded first. If the player starts the SMIL-File with a remote background image for the first time, the download is not completed and background will not shown.

Give me some time to find a more elegant solution. If you can live with local background files I can commit the current code.

@sagiadinos sagiadinos self-assigned this Mar 16, 2020
@adalidortiz
Copy link
Author

I'am wil try with overlays as you say.

Gracias !

sagiadinos added a commit that referenced this issue Apr 12, 2020
implemented working background image with tiling i
also in multizones
Implement issue #18
@sagiadinos
Copy link
Owner

I changed some internal calls in the lib and now garlic-player (build v0.3.0.430) support background images and background-repeat attribute as expected.
The workaround with a multi zone is not necessary anymore ;)

@adalidortiz
Copy link
Author

Hi Mr. Sagiadinos, thanks for the feature. How can i include this feature in my smil index. Can you share the tags?

Gracias !!!

@sagiadinos
Copy link
Owner

sagiadinos commented May 5, 2020

Hi,
Here you can find a small demonstration with a multizone playlist and par running images.

https://github.com/sagiadinos/garlic-player/blob/master/tests/data/smil/simple_par_with_backgrounds.smil

@adalidortiz
Copy link
Author

Many thanks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants