Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an entry from the cache is extreemly slow #7

Closed
DaveDavenport opened this issue Dec 4, 2011 · 4 comments
Closed

Deleting an entry from the cache is extreemly slow #7

DaveDavenport opened this issue Dec 4, 2011 · 4 comments
Labels

Comments

@DaveDavenport
Copy link

time glyrc cover --drop -c ~/.cache/gmpc/metadata/ -a "Jon Lord" -b "Jon Lord blues project - Live"; time glyrc cover -c ~/.cache/gmpc/metadata/ -f "local:-all" -a "Jon Lord" -b "Jon Lord blues project - Live"
Deleted 1 item from cache.

real 0m11.167s
user 0m10.980s
sys 0m0.170s

  • Artist : Jon Lord
  • Album : Jon Lord blues project - Live
  • Language : us
  • Type : cover

---- Triggering: local

=> 0 item(s) in total.

real 0m0.012s
user 0m0.000s
sys 0m0.010s

@sahib
Copy link
Owner

sahib commented Dec 4, 2011

Are you using an up-to-date version? Some of the last commits added a Sql LIMIT which should speed up things. If you're already on the latest version I might look into it once more.

@DaveDavenport
Copy link
Author

yes this was on a 160mb. sqlite db and a git from today.
It isn't a real issue atm in gmpc as it happens in a separate thread.

@DaveDavenport
Copy link
Author

Did some more measurements, currently deleting takes 35 seconds on a 195mb sqlite db.. This is unacceptable long.

@sahib
Copy link
Owner

sahib commented Dec 30, 2011

There was really this somewhere in the source:

g_strdup_printf("(...) LIMIT %d", (...), query->number + 1000000); 

..because of debugging purpose. It is faster now. :D
ouch

@sahib sahib closed this as completed Dec 30, 2011
sahib added a commit that referenced this issue May 1, 2012
emillon added a commit to emillon/glyr that referenced this issue May 1, 2012
* master:
  Fixed indentation
  Replaced levenshtein functions in autohelp.c through the API
  Replaced get_next_word with g_strsplit in autohelp.c
  Updated readme a tad sahib#11 (??)
  Updated readme a tad sahib#10 (??)
  Updated readme a tad sahib#9 (??)
  Updated readme a tad sahib#8 (??)
  Updated readme a tad sahib#7
  Updated readme a tad sahib#6
  Updated readme a tad sahib#5
  Updated readme a tad sahib#4
  Updated readme a tad sahib#3
  Updated readme a tad sahib#2
  Updated readme a tad
  Removed silly swig stuff in types.h

Conflicts:
	src/glyrc/autohelp.c
@ansedor ansedor mentioned this issue Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants