Crash when grabbing image from discogs

[DaveDavenport]

Backtrace:

---- Triggering: singerpictures 
[New Thread 0x7fffd6e47700 (LWP 3356)]
[Thread 0x7fffd6e47700 (LWP 3356) exited]
- glyr: Downloaderror: HTTP response code said error [errno:22]
  On URL: http://www.singerpictures.com/elmore-james-pictures.html
---- Triggering: discogs 
[New Thread 0x7fffd6e47700 (LWP 3358)]
[Thread 0x7fffd6e47700 (LWP 3358) exited]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe398a700 (LWP 3315)]
0x00007ffff3ae0b4a in ?? () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0  0x00007ffff3ae0b4a in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff5446d9e in memmove (__len=<optimized out>, __src=<optimized out>, __dest=0x7fffdc0271c2) at /usr/include/x86_64-linux-gnu/bits/string3.h:57
#2  transform_url (s=0x7fffdc0116a0, url=0x7fffdc026d50 "http://s.pixogs.com/images/default-release.png") at /tmp/buildd/glyr-1.0.2/lib/intern/photos/discogs.c:84
#3  photos_discogs_parse (capo=0x7fffdc0116a0) at /tmp/buildd/glyr-1.0.2/lib/intern/photos/discogs.c:126
#4  0x00007ffff543b625 in call_provider_callback (capo=0x7fffdc0116a0, userptr=userptr@entry=0xd46240, stop_download=stop_download@entry=0x7fffe3989747, 
    to_add=to_add@entry=0x7fffe3989754) at /tmp/buildd/glyr-1.0.2/lib/core.c:1288
#5  0x00007ffff543ad5f in async_download (url_list=<optimized out>, endmark_list=<optimized out>, s=s@entry=0x7fffe3989ad0, parallel_fac=<optimized out>, 
    timeout_fac=<optimized out>, asdl_callback=asdl_callback@entry=0x7ffff543b5d0 <call_provider_callback>, userptr=0xd46240, free_caches=free_caches@entry=1)
    at /tmp/buildd/glyr-1.0.2/lib/core.c:884
#6  0x00007ffff543c23c in execute_query (fetcher=<optimized out>, result_list=0x7fffe39899e0, stop_me=0x7fffe39899dc, source_list=<optimized out>, 
    query=0x7fffe3989ad0) at /tmp/buildd/glyr-1.0.2/lib/core.c:1616
#7  start_engine (query=query@entry=0x7fffe3989ad0, fetcher=<optimized out>, err=err@entry=0x7fffe3989ac0) at /tmp/buildd/glyr-1.0.2/lib/core.c:1710
#8  0x00007ffff54390a3 in glyr_get (query=0x7fffe3989ad0, e=0x7fffe3989ac0, length=0x0) at /tmp/buildd/glyr-1.0.2/lib/glyr.c:929
#9  0x0000000000485704 in ?? ()
#10 0x0000000000000000 in ?? ()

[DaveDavenport]

It looks like it expects two '-' in the url, it checks if it finds the first one, but not the second one. photos/discogs.c:82

[sahib]

Thanks for the report.
Should be fixed as of 7b1249d.

[DaveDavenport]

didn't have a crash anymore. so guess fixed 💃

[rrthomas]

Could you possibly make a release containing this fix? I just found gmpc (current development version) crashing because of this bug, so it'd be very nice to have the fix widely available. Thanks very much for fixing the bug before I found it!

[sahib]

@rrthomas: done.