-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #40
Comments
Hi sahidula, What is an endpoint in this context? I am looking to get involved with open source projects but I am still quite new. I am very familiar with Git, so version control shouldn't be an issue. Can you please point me in the right direction for getting started with adding unittests for this project? Thanks. |
@yemarnevets Just check for 2xx, 4xx and 5xx response, if any, from the HackerEarth API for some sample input. |
I'm not sure @mananpal1997 Probably what I wanted is to write tests to ensure quality of this project not for validation of HackerEarth's API validation. We should have tests in this project so that we can make sure new contributions aren't breaking anything. I'd encourage you to research on this a bit with @yemarnevets regarding what will be the best way to implement this. |
@mananpal1997 @yemarnevets Any update on this? |
If a make some time, I will collaborate with unit testing 😀 |
@aboglioli That'd be great! Let me know if you need help |
@sahildua2305 Hello, can I give this a try? |
@ChauTNguyen Sure 🙂 |
https://gist.github.com/ChauTNguyen/13ebafa8ea4f450ce40575bca3f78034 Hi, I'm working on it. However, I wanted to know if I'm starting it out correctly/heading in the right direction, so I wrote just a few basic unit tests. dependencies: selenium 3.0.2 I started out by covering:
I used sleep commands for the short compiles and refreshes (to give DOM time to render). |
@ChauTNguyen looks good. Can you please create a PR for the same? |
Hello, I am new to open source. Can I contribute to issue #44 ? |
@PrathameshPalaskar welcome. Thanks for showing interest to contribute to this project. As you can see there's already a pull request for this issue. Do you have any extra ideas about how you would want to do this? |
Re-opening this because the PR #44 was never submitted and this is likely up for grabs. |
Is this issue still open? I would like to contribute with some unit tests. |
No description provided.
The text was updated successfully, but these errors were encountered: