Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on masked_l1_loss #46

Closed
lovecambi opened this issue Nov 12, 2021 · 1 comment
Closed

Question on masked_l1_loss #46

lovecambi opened this issue Nov 12, 2021 · 1 comment

Comments

@lovecambi
Copy link

For the function masked_l1_loss (https://github.com/saic-mdal/lama/blob/main/saicinpainting/training/losses/feature_matching.py#L13),
I found weight_known=10 and weight_missing=0 in all config yaml files, so the masked_l1_loss won't calculate the difference on masked region. This seems counter-intuitive. Can you explain the reason?

@windj007
Copy link
Collaborator

Hi Sorry for late reply

No, there is no reason. L1 is only applied to the known part of the image and to the best of our knowledge, does not affect training. It is there just for historical reasons. You can turn L1 loss off altogether and everything should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants