use home folder of current user #46
Conversation
|
@simonschmeisser, thank you very much.
Originally I thought it would be nice, if users can set the But yesterday, when reading the criticism at FSO, I already considered to automatically set it to the user's homedir. As you have come to this conclusion independently and provided a PR implementing this, this will be the way to go. Probably this is the best solution, because one line of thinking (which should not be followed too strictly) is, that a configuration option is just a programmers easy way out, when unsure which default value to set. P.S.: I will try to remember to make another RC release next weekend, because I am away for the upcoming week. If I forget or miss to carry out this plan, feel free to remind me. |
|
Maybe the best solution would be to use the home dir as default and let users change it if desired. I say maybe because I haven't actually used this app just thought this should be easy to fix and went for it |
* [build-on-tags.yml] Adapt job name to commit b69fad8 * Update README.md with License link * Use current user's homedir as `Phone memory` path (#46) This should return the current user's home directory instead using a hard-coded default from the config file. Drawback: The `PhoneMemory` path is now fixed to the homedir. (not actually tested) * Updates for file translations/filecase.ts in sv (#47) * Translate translations/filecase.ts in sv 100% translated source file: 'translations/filecase.ts' on 'sv'. Co-authored-by: @eson57 via transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * [config.cpp] Document last change and put original line in comment * [filecase.qml] Add documenting comment * [filecase.qml] Fix typo in comment * Towards v0.4.3 (#50) * [ilecase.changes] Add entries for v0.4.2 * [filecase.spec] Pre-release version increase * [filecase.changes] Fix typo * [filecase.spec] Fix typo in comment --------- Co-authored-by: Simon Schmeisser <s.schmeisser@gmx.net> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
closes #15
This should return the current users home directory instead of hard coding it.
https://doc.qt.io/qt-5/qstandardpaths.html
`QDir::homePath would be another alternative
(not actually tested)