New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a bug in ReadAnnotationSetRefList #10

Closed

LoyieKing opened this issue Jul 7, 2019 · 1 comment

Assignees

LoyieKing commented Jul 7, 2019

annotation_set_ref_item format says

offset from the start of the file to the referenced annotation set or 0 if there are no annotations for this element.

https://github.com/sailro/Dexer/blob/master/Dexer/IO/DexReader.cs#L285-L286

    var size = reader.ReadUInt32();
    for (uint i = 0; i < size; i++)
    {
        var offset = reader.ReadUInt32();
        result.Add(ReadAnnotationSet(reader, offset));
    }

there should be

    for (uint i = 0; i < size; i++)
    {
        var offset = reader.ReadUInt();
        if (offset == 0)
            result.Add(new List<Annotation>(0));
        else
            result.Add(ReadAnnotationSet(offset));
    }

sailro closed this as completed in

307c511

sailro self-assigned this

Owner

sailro commented Jul 8, 2019

Good catch! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment