New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better exposure time fraction #187

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@dsiroky
Contributor

dsiroky commented Dec 17, 2015

No description provided.

@saimn

This comment has been minimized.

Owner

saimn commented Dec 17, 2015

It's fine, but this EXIF reading stuff is currently blocked by Pillow's breaking changes in 3.0 which is still not fixed (see #172):

  • You changed only the code specific to Pillow 2.9.0. With Pillow 3.0 it is not possible to get the numerator and denominator. I think one proposed fix on Pillow side is to use fractions.
  • Tests need to be updated, but Pillow 2.9.0 and 3.0 will not give the same result.
    So it is probably better to wait for Pillow to see if they will finally do something (but there is activity since ~1 month ...).

@saimn saimn added this to the 1.1.0 milestone Dec 17, 2015

@wiredfool

This comment has been minimized.

wiredfool commented Jan 1, 2016

Please test the new Pillow 3.1.0-rc1 release and give feedback.

@saimn

This comment has been minimized.

Owner

saimn commented Jan 7, 2016

Now that Pillow 3.1.0 is out, I got back on this and merged manually in 6e279bb
Thanks !

@saimn saimn closed this Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment